This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_sign_in] Correctly passes serverClientId to native libs#6691
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Nov 18, 2022
Merged
Conversation
camsim99
approved these changes
Nov 15, 2022
Contributor
camsim99
left a comment
There was a problem hiding this comment.
Android looks good to me!
Member
|
@stuartmorgan shall I merge this, do you have any concerns? |
Contributor
|
No concerns. Looking back at some dates, I think what happened is that the original end-to-end PR that supported this was written before I switched |
Member
|
Thanks for your continuing work on this, @wannabehero! |
Contributor
Author
|
Thanks for accepting this! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2022
* 19673b341 [camera]: Bump camerax_version (flutter/plugins#6709) * b8282424e [gh_actions]: Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (flutter/plugins#6610) * 2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. (flutter/plugins#6572) * 89cbf74c8 [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (flutter/plugins#6597) * 51d084453 [quick_actions] Fix Android integration test flake (flutter/plugins#6688) * b2fe01bc0 [google_sign_in] Correctly passes `serverClientId` to native libs (flutter/plugins#6691)
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 21, 2022
…utter#6691) * Correctly passes serverClientId to native libs * Bumps versions
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…#115656) * 19673b341 [camera]: Bump camerax_version (flutter/plugins#6709) * b8282424e [gh_actions]: Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (flutter/plugins#6610) * 2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. (flutter/plugins#6572) * 89cbf74c8 [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (flutter/plugins#6597) * 51d084453 [quick_actions] Fix Android integration test flake (flutter/plugins#6688) * b2fe01bc0 [google_sign_in] Correctly passes `serverClientId` to native libs (flutter/plugins#6691)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#115656) * 19673b341 [camera]: Bump camerax_version (flutter/plugins#6709) * b8282424e [gh_actions]: Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (flutter/plugins#6610) * 2ba4c0a70 [file_selector] Add getDirectoryPaths method to the file_selector_platform_interface. (flutter/plugins#6572) * 89cbf74c8 [quick_actions]Migrates all remaining components to Swift, and deprecate OCMock (flutter/plugins#6597) * 51d084453 [quick_actions] Fix Android integration test flake (flutter/plugins#6688) * b2fe01bc0 [google_sign_in] Correctly passes `serverClientId` to native libs (flutter/plugins#6691)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…utter#6691) * Correctly passes serverClientId to native libs * Bumps versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR compliments #5250 and #6034 to fully implement passing
serverClientIdto the native libs during channelled call.Current implementation works fine if the value is provided via the corresponding plist / json file. But if provided via code only – it doesn't work properly. This PR addresses that problem.
Fixes flutter/flutter#110099
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.